Repository navigation
[PR #2564/3a61149b backport][2.29] Pass generic arguments to AsyncContentCache.make_response override - #2565
Merged
pedro-psb merged 1 commit intoOct 8, 2026
Conversation
Pulpcore requires passing an extra argument to that method, but that breaks this override if it expects an exact set of arguments. (cherry picked from commit 3a61149)
4 tasks
pedro-psb
approved these changes
Oct 8, 2026
pedro-psb
deleted the
patchback/backports/2.29/3a61149bd3c2c0558d1b18dc8e5e98cea74efcd3/pr-2564
branch
October 8, 2026 18:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #2564 as merged into main (3a61149).
Pulpcore requires passing an extra argument to that method, but that breaks this override if it expects an exact set of arguments.
That causes this PR to be reverted and will enable having it back: pulp/pulpcore#8182
container 2.29 is the only supported branch that can be with pulpcore 3.121, which is expected to have that change in
make_response.📜 Checklist
See: Pull Request Walkthrough